Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(identity): remove deprecated items #3928

Merged
merged 3 commits into from
May 15, 2023

Conversation

tcoratger
Copy link
Contributor

@tcoratger tcoratger commented May 15, 2023

Description

Related: #3647.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@thomaseizinger
Copy link
Contributor

Are all of those definitely released already? I remember merging a PR here after we opened the merge window for the breaking changes.

@tcoratger
Copy link
Contributor Author

Are all of those definitely released already? I remember merging a PR here after we opened the merge window for the breaking changes.

@thomaseizinger I think any items that were flagged as deprecated in the identity folder may be removed from the codebase.

Indeed, I remembered this comment where I had eliminated in #3866 some residual calls to deprecated functions. It therefore made sense to me to eliminate all the remaining residues, especially since each time these are functions whose execution is guaranteed in exactly the same way by another updated function, what do you think?

Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that all deprecations are listed on https://docs.rs/libp2p-identity/0.1.2/libp2p_identity/index.html and thus can be removed with this release.

@mergify mergify bot merged commit 3cc6c7e into libp2p:master May 15, 2023
@tcoratger tcoratger deleted the identity-deprecated branch May 15, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants