fix(interop): use webrtc-direct as browser-to-server identifier
#3781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxinden
added a commit
to mxinden/test-plans
that referenced
this pull request
Apr 12, 2023
See multiformats/multiaddr#150 (comment) for context on discussion. - Renames the `webrtc` transport identifier to `webrtc-direct`. - Re-enables `webrtc-direct` support for rust-libp2p v0.51. Previously disabled in libp2p#160. See libp2p/rust-libp2p#3781 for corresponding change on the rust-libp2p side. - Leaves JS v0.41 and v0.42 untouched. To be done in a follow-up alongside JS dependency updates.
thomaseizinger
approved these changes
Apr 12, 2023
|
Fast-forwarded |
mxinden
added a commit
to libp2p/test-plans
that referenced
this pull request
Apr 19, 2023
See multiformats/multiaddr#150 (comment) for context on discussion. - Renames the `webrtc` transport identifier to `webrtc-direct`. - Re-enables `webrtc-direct` support for rust-libp2p v0.51. Previously disabled in #160. See libp2p/rust-libp2p#3781 for corresponding change on the rust-libp2p side. - Leaves JS v0.41 and v0.42 untouched. To be done in a follow-up alongside JS dependency updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See multiformats/multiaddr#150 (comment) for context on the rename.
Notes & open questions
I need to do the corresponding changes in https://github.com/libp2p/test-plans/. Draft here for now.
Change checklist