Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core)!: remove EitherTransport #3338

Merged
merged 17 commits into from
Jan 18, 2023
Merged

refactor(core)!: remove EitherTransport #3338

merged 17 commits into from
Jan 18, 2023

Conversation

thomaseizinger
Copy link
Contributor

Description

We don't need to define our own type here, we can simply implement Transport on either::Either.

Notes

Links to any relevant issues

Open Questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@thomaseizinger thomaseizinger changed the title refactor(core): remove EitherTransport refactor(core)!: remove EitherTransport Jan 17, 2023
@thomaseizinger thomaseizinger mentioned this pull request Jan 17, 2023
Closed
7 tasks
@mergify mergify bot mentioned this pull request Jan 17, 2023
Merged
4 tasks
jxs
jxs approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from 2650-remove-either-error to master January 17, 2023 23:06
@mergify
Copy link
Contributor

mergify bot commented Jan 17, 2023

This pull request has merge conflicts. Could you please resolve them @thomaseizinger? 🙏

@mergify mergify bot merged commit c18939f into master Jan 18, 2023
@mergify mergify bot deleted the 2650-remove-either-transport branch January 18, 2023 00:58
mxinden
mxinden reviewed Jan 18, 2023
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxinden mxinden mxinden left review comments

@jxs jxs jxs approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomaseizinger @jxs @mxinden