Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protocols/identify: Revise symbol naming #2927

Merged
merged 7 commits into from
Oct 4, 2022
Merged

protocols/identify: Revise symbol naming #2927

merged 7 commits into from
Oct 4, 2022

Conversation

jxs
Copy link
Member

@jxs jxs commented Sep 21, 2022

Description

Links to any relevant issues

#2217
#2215

Open Questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

thomaseizinger
thomaseizinger requested changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pushing this topic forward!

One note regarding the deprecation warnings, otherwise LGTM!

protocols/identify/examples/identify.rs Outdated Show resolved Hide resolved
protocols/identify/src/lib.rs Outdated Show resolved Hide resolved
@jxs jxs force-pushed the identify-revise-symbol-naming branch from 16f06ef to 29154bd Compare September 22, 2022 13:11
thomaseizinger
thomaseizinger reviewed Sep 23, 2022
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up on this! :)

Couple of more comments.

protocols/identify/CHANGELOG.md Show resolved Hide resolved
protocols/identify/src/behaviour.rs Outdated Show resolved Hide resolved
protocols/identify/src/lib.rs Outdated Show resolved Hide resolved
protocols/identify/src/lib.rs Outdated Show resolved Hide resolved
thomaseizinger
thomaseizinger approved these changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise LGTM!

protocols/identify/src/lib.rs Show resolved Hide resolved
thomaseizinger
thomaseizinger reviewed Sep 23, 2022
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@thomaseizinger
Copy link
Contributor

cargo doesn't seem to be too happy about the version bumps. I can recommend running cargo check --all-targets --all-features --workspace locally to see if everything is alright :)

@jxs
Copy link
Member Author

jxs commented Sep 23, 2022

cargo doesn't seem to be too happy about the version bumps. I can recommend running cargo check --all-targets --all-features --workspace locally to see if everything is alright :)

right, Thanks. Addressed above reviews ptal again Thomas :)

@jxs jxs force-pushed the identify-revise-symbol-naming branch from 6298d60 to d0468fb Compare September 23, 2022 15:26
thomaseizinger
thomaseizinger approved these changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for working on this!

@thomaseizinger thomaseizinger mentioned this pull request Sep 23, 2022
Open
@jxs jxs mentioned this pull request Sep 27, 2022
Merged
4 tasks
mxinden
mxinden approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks @jxs for the help.

Would you mind resolving the merge conflicts? Otherwise this is ready to merge from my side.

examples/ipfs-private.rs Show resolved Hide resolved
@jxs jxs force-pushed the identify-revise-symbol-naming branch 2 times, most recently from 33a4aa5 to 6a5e8bc Compare September 28, 2022 09:38
@jxs jxs force-pushed the identify-revise-symbol-naming branch from 6a5e8bc to f149395 Compare September 28, 2022 09:42
@jxs
Copy link
Member Author

jxs commented Sep 28, 2022

This looks good to me. Thanks @jxs for the help.

Would you mind resolving the merge conflicts? Otherwise this is ready to merge from my side.

done, ptal again Max :)

@thomaseizinger thomaseizinger changed the title protocols/identify: revise symbol naming protocols/identify: Revise symbol naming Sep 28, 2022
@mxinden
Copy link
Member

mxinden commented Sep 28, 2022 •
edited
Loading

@jxs generally we prefer merge commits over force pushes as that makes incremental reviews easier. Easy to see what changed since ones last review.

Don't worry about keeping the commit history clean. Pull requests are always squashed into a single commit.

@mxinden
Copy link
Member

mxinden commented Sep 28, 2022

Interoperability tests are failing again. I will merge here once we got those fixed. Sorry for the trouble.

You can follow along here: libp2p/test-plans#42

thomaseizinger
thomaseizinger approved these changes Sep 29, 2022
View reviewed changes
misc/metrics/CHANGELOG.md Outdated Show resolved Hide resolved
protocols/identify/src/lib.rs Outdated Show resolved Hide resolved
@jxs jxs force-pushed the identify-revise-symbol-naming branch from 9db1094 to 5112915 Compare October 3, 2022 21:04
@jxs
Copy link
Member Author

jxs commented Oct 3, 2022

Pulled from latest master, and fixed the remaining intradoc link problems. CI is finally green, ptal again :)

@thomaseizinger
Copy link
Contributor

Let's get it in!

@thomaseizinger thomaseizinger merged commit a7a96e5 into libp2p:master Oct 4, 2022
@thomaseizinger thomaseizinger mentioned this pull request Oct 4, 2022
Merged
4 tasks
umgefahren pushed a commit to umgefahren/rust-libp2p that referenced this pull request Mar 8, 2024
@jxs
protocols/identify: Revise symbol naming (libp2p#2927)
cc9792b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaseizinger thomaseizinger thomaseizinger approved these changes

@mxinden mxinden mxinden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jxs @thomaseizinger @mxinden