-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
transports/noise: fix compilation #2264
Conversation
For crate that depends on `generic-array = { version = "0.14.3", features = ["serde", "more_lengths"] }` It's seems that `as_ref()` is ambiguous.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Milerius. Appreciate the patch.
In case you would need a backport of this change, please see #2231 (comment).
It would be lovely. It seems that our project doesn't compile anymore if I use this last commit - a bit new into rust/cargo. Could you please tell me a bit more about how to achieve that? Personally we use: |
Double checking here: You are referring to tag |
no sorry, I'm referring to this commit: 20183c1 But otherwise I would love to have some inputs on the upgrade regarding:
I've read https://github.com/libp2p/rust-libp2p/pull/2191/files#r692527903 but since I'm new to libp2p and rust I've some struggling understanding the update path ^^' From what I understand NetworkBehaviourAction doesn't take an event as second parameter but an handler - a bit lost ^^' |
…res (libp2p#2264) For crate that depends on `generic-array = { version = "0.14.3", features = ["serde", "more_lengths"] }` It's seems that `as_ref()` is ambiguous.
May I ask why you are not running on a released version of rust-libp2p but 20183c1 instead? In regards to your compile time errors, you would need to adjust the trait parameters of rust-libp2p/protocols/gossipsub/src/behaviour.rs Lines 197 to 198 in 937b59d
|
Thanks - then I will update directly to last libp2p -thanks for the input |
* transports/noise: Bump snow and rand * transports/noise: Bump crate version * transports/noise: Fix compilation with additional generic-array features (#2264) For crate that depends on `generic-array = { version = "0.14.3", features = ["serde", "more_lengths"] }` It's seems that `as_ref()` is ambiguous. * .github/workflows/ci.yml: Use clang 11 (#2233) * transports/noise/CHANGELOG: Add entry Co-authored-by: Alexander Popiak <[email protected]> Co-authored-by: Sztergbaum Roman <[email protected]>
* transports/noise: Bump snow and rand * transports/noise: Bump crate version * transports/noise: Fix compilation with additional generic-array features (#2264) For crate that depends on `generic-array = { version = "0.14.3", features = ["serde", "more_lengths"] }` It's seems that `as_ref()` is ambiguous. * .github/workflows/ci.yml: Use clang 11 (#2233) * transports/noise/CHANGELOG: Add entry Co-authored-by: Alexander Popiak <[email protected]> Co-authored-by: Sztergbaum Roman <[email protected]>
…res (libp2p#2264) For crate that depends on `generic-array = { version = "0.14.3", features = ["serde", "more_lengths"] }` It's seems that `as_ref()` is ambiguous.
For crate that depends on
generic-array = { version = "0.14.3", features = ["serde", "more_lengths"] }
It's seems thatas_ref()
is ambiguous.more-lengths
features seem to create this problem.