Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Identity multihash #564

Closed
ghost opened this issue Oct 12, 2018 · 1 comment
Closed

Support Identity multihash #564

ghost opened this issue Oct 12, 2018 · 1 comment
Labels
getting-started Issues that can be tackled if you don't know the internals of libp2p very well priority:nicetohave

Comments

@ghost
Copy link

ghost commented Oct 12, 2018

Multihash does not currently have a proper spec, but the canonical Go implementation includes an "identity" (null) hash that maps a byte array onto itself.

#555 depends on this
@ghost ghost self-assigned this Oct 12, 2018
@tomaka tomaka added the getting-started Issues that can be tackled if you don't know the internals of libp2p very well label Feb 21, 2019
@tomaka
Copy link
Member

tomaka commented Sep 24, 2019

This has been done in #1230/#1237

@tomaka tomaka closed this as completed Sep 24, 2019
jxs added a commit to jxs/rust-libp2p that referenced this issue Jan 15, 2024
@jxs
feat(gossipsub): Remove peer_topics and topic_peers (libp2p#564)
c223884 
* remove peer_topics, use connected_peers instead

* remove topic_peers, use only connected

* clippy

* return earlier if number of peers is insuficient

* fix queue length and timeout config parameters

* remove unrequired curly braces

* add PeerId to ListenFailure

* remove peer from connected_peers if connection fails

* avoid panic'ing when peer is not on the connected peer list

* cargo clippy

* update CHANGELOG.md and increase version to pass CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
getting-started Issues that can be tackled if you don't know the internals of libp2p very well priority:nicetohave
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gnunicorn @tomaka