Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autonat: migrate to quick-protobuf-codec #4489

Closed
Tracked by #2500
, #4011
...
thomaseizinger opened this issue Sep 12, 2023 · 0 comments · Fixed by #4787
Closed
Tracked by #2500
, #4011
...

autonat: migrate to quick-protobuf-codec #4489

thomaseizinger opened this issue Sep 12, 2023 · 0 comments · Fixed by #4787
Labels
difficulty:moderate help wanted

Comments

@thomaseizinger
Copy link
Contributor

thomaseizinger commented Sep 12, 2023 •
edited
Loading

In /misc we have the quick-protobuf-codec crate which makes working with protobuf structs over streams quite easy as you only need to construct a asynchronous_codec::Framed type and can read and write full protobuf messages on any Async{Read,Write}.

We should make use of this in libp2p-autonat.

See https://docs.rs/quick-protobuf-codec.

Previous tracking issue: #2500
@thomaseizinger thomaseizinger mentioned this issue Sep 12, 2023
Closed
@thomaseizinger thomaseizinger mentioned this issue Sep 19, 2023
Closed
@thomaseizinger thomaseizinger mentioned this issue Oct 5, 2023
Closed
@thomaseizinger thomaseizinger mentioned this issue Nov 2, 2023
Merged
4 tasks
@mergify mergify bot closed this as completed in #4787 Nov 2, 2023
mergify bot pushed a commit that referenced this issue Nov 2, 2023
@thomaseizinger
refactor(autonat): use quick-protobuf-codec
d05d836 
Resolves: #4489.
Resolves: #2500.

Pull-Request: #4787.
umgefahren pushed a commit to umgefahren/rust-libp2p that referenced this issue Mar 8, 2024
@thomaseizinger
refactor(autonat): use quick-protobuf-codec
426606d 
Resolves: libp2p#4489.
Resolves: libp2p#2500.

Pull-Request: libp2p#4787.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty:moderate help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(autonat): use quick-protobuf-codec libp2p/rust-libp2p
1 participant
@thomaseizinger