Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

identify: Push changes in listen protocols via identify push #3613

Closed
thomaseizinger opened this issue Mar 15, 2023 · 0 comments · Fixed by #3980
Closed

identify: Push changes in listen protocols via identify push #3613

thomaseizinger opened this issue Mar 15, 2023 · 0 comments · Fixed by #3980
Labels
help wanted priority:nicetohave

Comments

@thomaseizinger
Copy link
Contributor

Description

See libp2p/specs#530 (comment).

Depends on #2680.

Motivation

Have other nodes always have an up-to-date list of our supported protocols.

Current Implementation

Are you planning to do it yourself in a pull request?

No.
This was referenced May 23, 2023
Merged
Merged
@mergify mergify bot closed this as completed in #3980 May 25, 2023
mergify bot pushed a commit that referenced this issue May 25, 2023
@thomaseizinger
feat(identify): push changed listen protocols to remote
137443b 
Now that we have the infrastructure for notifying protocols about changes to our listen protocols, we can use this to actively push those changes to our remotes. This allows other peers to re-configure themselves with very low-latency instead of waiting for the periodic identify event.

Resolves: #3613.

Pull-Request: #3980.
@thomaseizinger thomaseizinger mentioned this issue Aug 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted priority:nicetohave
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(identify): push changed listen protocols to remote libp2p/rust-libp2p
1 participant
@thomaseizinger