Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend NetworkBehaviourAction to add and remove listeners #3291

Closed
dariusc93 opened this issue Dec 30, 2022 · 1 comment · Fixed by #3292
Closed

Extend NetworkBehaviourAction to add and remove listeners #3291

dariusc93 opened this issue Dec 30, 2022 · 1 comment · Fixed by #3292

Comments

@dariusc93
Copy link
Member

Description

Extend NetworkBehaviourAction with NetworkBehaviourAction::ListenOn and NetworkBehaviourAction::RemoveListener to allow adding or removing a listener within the NetworkBehaviour

Motivation

One project that I am working on is an attempt at connecting to a relay automatically, which could benefit from this by emitting an event to listen on the relay and be able to remove it by using the listener id later if needed (eg relay becoming unreliable). Current workaround is emitting an event which is then seen when polling the swarm to then listen to (and soon remove) the address there.

Open questions

Are you planning to do it yourself in a pull request?

Maybe
@dariusc93 dariusc93 mentioned this issue Dec 31, 2022
Merged
4 tasks
@thomaseizinger
Copy link
Contributor

Related: #3040

I am in favor of this, I think it makes sense to offer all capabilities through NetworkBehaviour and slowly but surely shrink the public API of Swarm.

@thomaseizinger thomaseizinger mentioned this issue Jan 9, 2023
Closed
@thomaseizinger thomaseizinger mentioned this issue May 8, 2023
Closed
@mergify mergify bot closed this as completed in #3292 Jun 9, 2023
mergify bot pushed a commit that referenced this issue Jun 9, 2023
@dariusc93
feat(swarm): allow NetworkBehaviours to create and remove listeners
c2230f9 
This extends `ToSwarm` to add `ToSwarm::ListenOn` and `ToSwarm::RemoveListener`, which allows creating and removing listeners from a `NetworkBehaviour`.

Resolves #3291.

Pull-Request: #3292.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(swarm): allow NetworkBehaviours to create and remove listeners dariusc93/rust-libp2p
2 participants
@dariusc93 @thomaseizinger