Skip to content
This repository has been archived by the owner on Feb 11, 2020. It is now read-only.

Lead maintainer #37

Merged
merged 2 commits into from
May 7, 2018
Merged

Lead maintainer #37

merged 2 commits into from
May 7, 2018

Conversation

daviddias
Copy link
Member

No description provided.

Copy link
Contributor

@pgte pgte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@daviddias daviddias merged commit c777ae7 into master May 7, 2018
@daviddias daviddias deleted the lead-maintainer branch May 7, 2018 07:59
@ghost ghost removed the in progress label May 7, 2018
@daviddias
Copy link
Member Author

@pgte you can now do your first release of this module :)

@pgte
Copy link
Contributor

pgte commented May 7, 2018

@diasdavid aegir release is failing with the error:

remote: error: GH006: Protected branch update failed for refs/heads/master.
remote: error: Required status check "continuous-integration/jenkins/pr-merge" is expected. At least 1 approving review is required by reviewers with write access.
To github.com:libp2p/js-peer-book.git

I think this happens because the master branch is protected from direct pushes. I looked through the maintainer protocol and couldn't find any reference to this... How can this work with the aegis release workflow?

@victorb
Copy link
Member

victorb commented May 7, 2018

@pgte I'm currently looking into this issue. For now you can disable the direct push protection, while we find a solution.

@pgte
Copy link
Contributor

pgte commented May 7, 2018

@victorbjelkholm I don't think I have permissions to do that..

@daviddias
Copy link
Member Author

ref issue ipfs/aegir#225

@victorb
Copy link
Member

victorb commented May 7, 2018

@pgte settings have been changed, can you please try again?

@pgte
Copy link
Contributor

pgte commented May 7, 2018

@victorbjelkholm tried pushing, same result.

@pgte
Copy link
Contributor

pgte commented May 7, 2018

All done now, released version 0.8.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants