feat(keychain): add support for ed25519 and secp keys #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
vasco-santos
approved these changes
Aug 5, 2020
src/keychain/index.js
Outdated
| @@ -174,7 +176,7 @@ class Keychain { | |||
| * @param {int} size - The key size in bits. | |||
There was a problem hiding this comment.
default value and optional?
There was a problem hiding this comment.
I updated this to be optional and updated the logic to remove the default. 0 doesn't really make sense, so now this just checks the size when it matters (when type is rsa). Also updated the api docs to reflect this.
vasco-santos
approved these changes
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support in the keychain for ed25519 and secp256k1 keys.
unblocks #669
unblocks usage of these keys in js-ipfs and any other apps leveraging the keychain