feat: keychain #631
feat: keychain #631
Conversation
Fixes #2
Add syntax highlighting to README
This commit updates all CI scripts to the latest version
Updating CI files
Persist the key info in the store
test: key name comparision
* test: openssl interop is now the responsibility of libp2p-crypto * feat: use libp2p-crypto, not node-forge, for key management * fix: use libp2p-crypto.pbkdf, not node-forge * fix: do not ship CMS This removes all depencies on node-forge * test: update dependencies * test: remove dead code
BREAKING CHANGE: all API methods with peer-info parameters or return values were changed. You can check the API.md document, in order to check the new values to use
Co-Authored-By: Jacob Heun <[email protected]>
Co-Authored-By: Jacob Heun <[email protected]>
Bumps [datastore-level](https://github.com/ipfs/js-datastore-level) from 0.14.1 to 1.0.0. - [Release notes](https://github.com/ipfs/js-datastore-level/releases) - [Changelog](https://github.com/ipfs/js-datastore-level/blob/master/CHANGELOG.md) - [Commits](ipfs/js-datastore-level@v0.14.1...v1.0.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
Co-Authored-By: Jacob Heun <[email protected]>
Bumps [datastore-fs](https://github.com/ipfs/js-datastore-fs) from 0.9.1 to 1.0.0. - [Release notes](https://github.com/ipfs/js-datastore-fs/releases) - [Changelog](https://github.com/ipfs/js-datastore-fs/blob/master/CHANGELOG.md) - [Commits](ipfs/js-datastore-fs@v0.9.1...v1.0.0) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
vasco-santos
force-pushed
the
feat/keychain
branch
4 times, most recently
from
1df9134
to
b1a2b8a
Compare
vasco-santos
force-pushed
the
feat/keychain
branch
from
f240930
to
c9d776a
Compare
There was a problem hiding this comment.
Just a general note in addition to the other comments, I think this PR would be a bit easier to review and would maintain an easier historical squash reference if it was split into 2 PRs.
- PR1: Just include libp2p-keychain in libp2p. This would let us run tests and just use keychain via
require('libp2p/src/keychain'). This also ensure the squash commit has the "as is" keychain implementation from existing contributors. - PR2: Integrate directly into libp2p. This just makes it easier to see if any keychain code needs to be touched during integration
| // ... | ||
| const listenMa = libp2p.transportManager.getAddrs() | ||
| // [ <Multiaddr 047f00000106f9ba - /ip4/127.0.0.1/tcp/63930> ] | ||
|
|
There was a problem hiding this comment.
This whole added block already exists, this is adding duplicate data.
There was a problem hiding this comment.
Removing this should also fix the formatting below as it isn't properly closing the code blocks
|
|
||
| ```js | ||
| const keyInfo = await libp2p.keychain.createKey('keyTest', 'rsa', 4096) | ||
| const enc = await libp2p.keychain.cms.encrypt('keyTest', Buffer.from('data')) |
There was a problem hiding this comment.
This is an encrypt example, but this section is decrypt
| this.datastore = this._options.datastore | ||
| this.keychain = this._options.keychain |
There was a problem hiding this comment.
_options.keychain is an object, not a KeyChain, this will break
| @@ -168,6 +172,9 @@ class Libp2p extends EventEmitter { | |||
| this.peerRouting = peerRouting(this) | |||
| this.contentRouting = contentRouting(this) | |||
|
|
|||
| // Keychain | |||
| this.keychain = this._options._keychain || new NoKeychain() | |||
There was a problem hiding this comment.
Why NoKeychain? It's just throwing errors whenever you try to use it. Just leave it undefined and let type errors happen.
| await keychain.importPeer('self', peerId) | ||
| } | ||
|
|
||
| options._keychain = keychain |
There was a problem hiding this comment.
Having keychain and _keychain on options is confusing. Why not move the keychain creation in to the libp2p constructor? We can create libp2p then do the keychain await stuff before returning the libp2p instance.
This PR is part of the PeerStore improvements EPIC and tackles part of the milestone 4 - KeyChain.
Points to note:
./src/keychainand its tests under./test/keychain.Libp2p.createand follows the same approach asjs-ipfsdid https://github.com/ipfs/js-ipfs/blob/master/packages/ipfs/src/core/components/init.js#L178-L257 (This will not be needed anymore in ipfs, you can also see this temporary commit with the new usage: ipfs/js-ipfs@1a342c5)Note on Merging:
Right now the plan (obtained from
libp2p-keychainPR) is to:This replaces #525 because the other PR was super outdated and complex to rebase at this point.