Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename peer-store properties #613

Merged
merged 2 commits into from
Apr 27, 2020
Merged

chore: rename peer-store properties #613

merged 2 commits into from
Apr 27, 2020

Conversation

vasco-santos
Copy link
Member

@vasco-santos vasco-santos commented Apr 24, 2020 •
edited
Loading

Per libp2p/js-libp2p#610 review, we are renaming MultiaddrInfo into Address, and peerStore.get return value from PeerData into peer with an addresses property instead of multiaddrInfos.

This needs:

@vasco-santos vasco-santos mentioned this pull request Apr 24, 2020
Merged
1 task
@vasco-santos vasco-santos force-pushed the chore/rename-peer-store-properties branch from c236557 to 7039cd0 Compare April 24, 2020 14:21
This was referenced Apr 24, 2020
Merged
Merged
jacobheun
jacobheun approved these changes Apr 24, 2020
View reviewed changes
Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just some minor fixes.

src/index.js Show resolved Hide resolved
src/index.js Show resolved Hide resolved
src/index.js Show resolved Hide resolved
src/peer-store/README.md Show resolved Hide resolved
@vasco-santos vasco-santos force-pushed the chore/rename-peer-store-properties branch from 3d6c5a8 to 9e0097c Compare April 27, 2020 06:55
@vasco-santos
Copy link
Member Author

vasco-santos commented Apr 27, 2020 •
edited
Loading

[email protected] released as beta. This should be good to go

@vasco-santos vasco-santos merged commit 7627f96 into 0.28.x Apr 27, 2020
@achingbrain achingbrain deleted the chore/rename-peer-store-properties branch May 18, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobheun jacobheun jacobheun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vasco-santos @jacobheun