Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use raw asn1js int value to improve performance #2788

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

achingbrain
Copy link
Member

@achingbrain achingbrain commented Oct 26, 2024

When converting an asn1js Integer to a base64url encoded string, use the raw byte value instead of converting it to a string, then a bigint, then bytes.

This greatly improves performance with a large peer store, and RSA peers in general, particularly during startup.

Before:

image

After:

image

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

When converting an asn1js Integer to a base64url encoded string,
use the raw byte value instead of converting it to a string, then
a bigint, then bytes.
@achingbrain achingbrain requested a review from a team as a code owner October 26, 2024 07:33
@achingbrain achingbrain changed the title fix: use raw int value to improve performance fix: use raw asn1js int value to improve performance Oct 26, 2024
@achingbrain achingbrain merged commit c4399dc into main Oct 28, 2024
32 checks passed
@achingbrain achingbrain deleted the fix/use-raw-int-value branch October 28, 2024 08:07
@achingbrain achingbrain mentioned this pull request Oct 28, 2024
@SgtPooki
Copy link
Member

Wow good find

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants