feat: add tls connection encrypter #2377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
force-pushed
the
feat/add-tls-connection-encrypter
branch
from
bf3984f
to
2b7b7c9
Compare
|
One final compliance test is not passing - the server side of the connection doesn't notice the client closing it's end so it remains open and the test hangs until it times out. |
achingbrain
force-pushed
the
feat/add-tls-connection-encrypter
branch
from
2b7b7c9
to
6e8515e
Compare
Encrypts connections using TLS 1.3. Spec: https://github.com/libp2p/specs/blob/master/tls/tls.md This connection encrypter primarily targets TCP connections and is notable for having fewer round trips during connection establishment than Noise.
achingbrain
force-pushed
the
feat/add-tls-connection-encrypter
branch
from
6e8515e
to
b930254
Compare
|
Streaming performance is comparable to noise, connection establishment is slower, which is unexpected: https://observablehq.com/@libp2p-workspace/performance-dashboard?branch=83b4e5da914c6dbcc8a04d23a8dca4df3419f33e I think this may be because Node.js' TLS1.3 implementation doesn't support 0-RTT connection establishment (🤦♂️ if so) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encrypts connections using TLS 1.3.
Spec: https://github.com/libp2p/specs/blob/master/tls/tls.md
This connection encrypter primarily targets TCP connections on Node.js/Electron/React Native and is notable for having fewer round trips during connection establishment than Noise.
The Node.js TLS module has a fair few more users than Noise so it will be interesting to see how streaming performance compares between the two.
Change checklist
TODO