Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove extra deps #2340

Merged
merged 3 commits into from
Jan 6, 2024
Merged

fix: remove extra deps #2340

merged 3 commits into from
Jan 6, 2024

Conversation

achingbrain
Copy link
Member

@achingbrain achingbrain commented Dec 30, 2023

Remove extra/add missing deps shown by ipfs/aegir#1426

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

Remove extra/add missing deps shown by ipfs/aegir#1426

Depends on #2339
@achingbrain achingbrain requested a review from a team as a code owner December 30, 2023 17:54
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should wait till ipfs/aegir#1426 is merged and aegir is upgraded, so that we can re-run the fixed dep-check on CI before merging this PR.

packages/utils/package.json Outdated Show resolved Hide resolved
@achingbrain
Copy link
Member Author

Aegir is upgraded.

@achingbrain achingbrain merged commit 53e83ee into main Jan 6, 2024
22 checks passed
@achingbrain achingbrain deleted the fix/remove-extra-deps branch January 6, 2024 14:57
@achingbrain achingbrain mentioned this pull request Jan 6, 2024
This was referenced Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants