fix!: remove event emitter type from interfaces #2196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
force-pushed
the
fix/remove-event-listener
branch
from
2225963
to
ce6ee74
Compare
achingbrain
changed the title
|
Blocked on ChainSafe/js-libp2p-gossipsub#470 |
maschad
approved these changes
Nov 3, 2023
achingbrain
force-pushed
the
release-v1.0
branch
6 times, most recently
from
d39bc23
to
d7d004e
Compare
should be unblocked now |
All code should be using `TypedEventEmitter` instead of `EventEmitter` so remove the re-export from the interfaces package. BREAKING CHANGE: removed EventEmitter re-export - please use TypedEventEmitter instead
achingbrain
force-pushed
the
fix/remove-event-listener
branch
from
8e1e469
to
07de97d
Compare
maschad
pushed a commit
to maschad/js-libp2p
that referenced
this pull request
Nov 27, 2023
All code should be using `TypedEventEmitter` instead of `EventEmitter` so remove the re-export from the interfaces package. BREAKING CHANGE: removed EventEmitter re-export - please use TypedEventEmitter instead
This was referenced Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All code should be using
TypedEventEmitterinstead ofEventEmitterso remove the re-export from the interfaces package.BREAKING CHANGE: removed EventEmitter re-export - please use TypedEventEmitter instead
Change checklist