fix!: remove peer refresh #1731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
js-libp2p occasionally gets all peer routers to run a query for it's own node id. The only module that actually requires this is kad-dht in order to insure it has peers when it runs a query and it does this anyway since it's part of the spec. libp2p/js-libp2p-kad-dht#457 also updates kad-dht to pause all executed queries until the self-query has run. Consequently this is redundant and just creates unecessary work.
Merged
maschad
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
js-libp2p occasionally gets all peer routers to run a query for it's own node id.
The only module that actually requires this is kad-dht in order to insure it has peers when it runs a query and it does this anyway since it's part of the spec.
libp2p/js-libp2p-kad-dht#457 also updates kad-dht to pause all executed queries until the self-query has run.
Consequently this is redundant and just creates unnecessary work.
BREAKING CHANGE: the redundant internal peer refresh have been removed along with the
peerRouting.refreshManagerconfig key