fix: use @libp2p/keychain module instead of bundling source code #1569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The @libp2p/keychain module has the keychain code split out from this module so use that instead of bundling the code here. It's also dropped it's dependency on `node-forge` so it's now only in `@libp2p/crypto`.
prathamesh0
pushed a commit
to cerc-io/js-libp2p
that referenced
this pull request
Mar 24, 2023
…p2p#1569) The @libp2p/keychain module has the keychain code split out from this module so use that instead of bundling the code here. It's also dropped it's dependency on `node-forge` so it's now only in `@libp2p/crypto`.
ashwinphatak
pushed a commit
to cerc-io/js-libp2p
that referenced
this pull request
Mar 24, 2023
* chore: upgrade aegir (libp2p#1566) Updates aegir, fixes all linting and dep issues. Co-authored-by: achingbrain <[email protected]> * Fix linting errors * Add package-lock.json * fix: use @libp2p/keychain module instead of bundling source code (libp2p#1569) The @libp2p/keychain module has the keychain code split out from this module so use that instead of bundling the code here. It's also dropped it's dependency on `node-forge` so it's now only in `@libp2p/crypto`. * Fix dependencies * Avoid upgrading go-libp2p for interop tests --------- Co-authored-by: Chad Nehemiah <[email protected]> Co-authored-by: achingbrain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The @libp2p/keychain module has the keychain code split out from this module so use that instead of bundling the code here.
It's also dropped it's dependency on
node-forgeso it's now only in@libp2p/crypto.