chore: add yamux to all tests #1375
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wemeetagain looks like there are some differences in behaviour between yamux and mplex, mostly around error codes? |
Wherever we support mplex, add yamux
achingbrain
force-pushed
the
chore/add-yamux-everywhere
branch
from
54e0aeb to
162b31c
Compare
|
looks like that ERR_UNDER_READ is coming from multistream select. Will look into this later |
|
I opened up #1579 in favour of this |
|
Closing in favour of #1579 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wherever we support mplex, add yamux