Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Remove parallel dialling #2090

Closed
maschad opened this issue Sep 28, 2023 · 0 comments · Fixed by #2251
Closed

refactor: Remove parallel dialling #2090

maschad opened this issue Sep 28, 2023 · 0 comments · Fixed by #2251
Assignees
@maschad
Labels
kind/architecture Core architecture of project P1 High: Likely tackled by core team if no one steps up topic/perf Performance

Comments

@maschad
Copy link
Member

maschad commented Sep 28, 2023

As it stands we currently have parallel dials per peer disabled by default, post #2010 there is currently no use case for parallel dials per peer given that if we have ranked multiaddrs based on likelihood of success, it would be inefficient to dial multiaddrs that could potentially fail.
@maschad maschad added the need/triage Needs initial labeling and prioritization label Sep 28, 2023
@maschad maschad moved this to 🛠️ Todo in js-libp2p Sep 28, 2023
@maschad maschad added kind/architecture Core architecture of project need/triage Needs initial labeling and prioritization topic/perf Performance P1 High: Likely tackled by core team if no one steps up and removed need/triage Needs initial labeling and prioritization labels Sep 28, 2023
@maschad maschad mentioned this issue Oct 1, 2023
Closed
@maschad maschad changed the title Refactor: Remove parallel dialling refactor: Remove parallel dialling Oct 2, 2023
@maschad maschad removed the need/triage Needs initial labeling and prioritization label Oct 2, 2023
@maschad maschad self-assigned this Oct 2, 2023
@maschad maschad moved this from 🛠️ Todo to 🏃‍♀️In Progress in js-libp2p Oct 4, 2023
@maschad maschad moved this from 🏃‍♀️In Progress to 🛠️ Todo in js-libp2p Oct 5, 2023
maschad added a commit to maschad/js-libp2p that referenced this issue Oct 18, 2023
@maschad
fixremove parallel dialling (libp2p#2090)
5985dcb
@maschad maschad mentioned this issue Oct 18, 2023
Merged
3 tasks
@maschad maschad moved this from 🛠️ Todo to 🏃‍♀️In Progress in js-libp2p Oct 18, 2023
@maschad maschad moved this from 🏃‍♀️In Progress to 🥸In Review in js-libp2p Oct 18, 2023
@maschad maschad mentioned this issue Oct 23, 2023
Closed
3 tasks
achingbrain pushed a commit to maschad/js-libp2p that referenced this issue Oct 31, 2023
@maschad @achingbrain
refactor!: remove per-peer parallel dialling (libp2p#2090)
4101b23 
Since we are now dialling one peer at a time as a means of smarter dialling, we
no longer need the option to control the concurrency of parallel dials across
a single peers' multiaddrs.

Closes libp2p#2090
achingbrain added a commit that referenced this issue Oct 31, 2023
@maschad @achingbrain
refactor!: remove per-peer parallel dialling (#2163)
66fbdb9 
Since we are now dialling one peer at a time as a means of smarter dialling, we no longer need the option to control the concurrency of parallel dials across the multiaddrs of a single peer.

Closes #2090

---------

Co-authored-by: Alex Potsides <[email protected]>
@maschad maschad closed this as completed Nov 2, 2023
@github-project-automation github-project-automation bot moved this from 🥸In Review to 🎉Done in js-libp2p Nov 2, 2023
achingbrain pushed a commit that referenced this issue Nov 21, 2023
@maschad @achingbrain
refactor!: remove per-peer parallel dialling (#2090)
1f5a061 
Since we are now dialling one peer at a time as a means of smarter dialling, we
no longer need the option to control the concurrency of parallel dials across
a single peers' multiaddrs.

Closes #2090
@achingbrain achingbrain mentioned this issue Nov 21, 2023
Merged
3 tasks
achingbrain pushed a commit that referenced this issue Nov 21, 2023
@maschad @achingbrain
refactor!: remove per-peer parallel dialling (#2090)
bf9f303 
Since we are now dialling one peer at a time as a means of smarter dialling, we
no longer need the option to control the concurrency of parallel dials across
a single peers' multiaddrs.

Closes #2090
achingbrain added a commit that referenced this issue Nov 21, 2023
@achingbrain @maschad
refactor!: remove per-peer parallel dialling (#2090) (#2251)
bb6ceb1 
Since we are now dialling one peer at a time as a means of smarter dialling, we
no longer need the option to control the concurrency of parallel dials across
a single peers' multiaddrs.

Closes #2090

Co-authored-by: chad <[email protected]>
@github-actions github-actions bot mentioned this issue Nov 21, 2023
Merged
maschad added a commit to maschad/js-libp2p that referenced this issue Nov 27, 2023
@achingbrain @maschad
refactor!: remove per-peer parallel dialling (libp2p#2090) (libp2p#2251)
d805a31 
Since we are now dialling one peer at a time as a means of smarter dialling, we
no longer need the option to control the concurrency of parallel dials across
a single peers' multiaddrs.

Closes libp2p#2090

Co-authored-by: chad <[email protected]>
@github-actions github-actions bot mentioned this issue Nov 29, 2023
Closed
This was referenced Jan 18, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maschad maschad

Labels
kind/architecture Core architecture of project P1 High: Likely tackled by core team if no one steps up topic/perf Performance
Projects
js-libp2p
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor!: remove per-peer parallel dialling (#2090) libp2p/js-libp2p
1 participant
@maschad