[WIP] Move to pull-streams #18
Conversation
| if (typeof options === 'function') { | ||
| callback = options | ||
| cb = options |
There was a problem hiding this comment.
Let's continue to use callback for top level callback and cb for internals (like run-series cb)
There was a problem hiding this comment.
No description provided.
|
@whyrusleeping @jbenet Would like your thoughts on a extension to WebSockets to enable halfClosed pipes - pull-stream/pull-ws#13 (comment), it might just be a pattern we need to apply to other transports anyway. |
| return cb(null, [ma]) | ||
| } | ||
|
|
||
| const conn = new Connection(socket) |
There was a problem hiding this comment.
|
@diasdavid as long as we are using something on top, like a stream muxer that has an end handshake we should be fine. At least as far as I understand |
|
@dignifiedquire not quite, because spdy also has a closing ceremony (it believes it is on top of TCP), so it will call .end/.close, and not wait to receive the signal to close graciously, causing the same problem. |
|
😢 |
| cb(null, [listeningMultiaddr]) | ||
| } | ||
|
|
||
| return listener |
There was a problem hiding this comment.
It is missing to bubble up the events from the listener:
- event: 'listening'
- event: 'close'
- event: 'connection'
- event: 'error'
See interface-transport.
- Add tests for the above
|
Last things to do:
|
no timeout by default as far as I know on dial |
|
interface-transport tests also fail here :( @dignifiedquire |
CI looks pretty green to me after I gave circle a non cache kick |
Investigate
delay. Ref pull-stream/pull-ws#13