This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
fix: socket close event not working in browser #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
approved these changes
Sep 20, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Sep 21, 2022
## [3.0.4](v3.0.3...v3.0.4) (2022-09-21) ### Bug Fixes * remove set timeout ([#182](#182)) ([23518b0](23518b0)), closes [#121](#121) * socket close event not working in browser ([#183](#183)) ([9076b5b](9076b5b)), closes [#179](#179) ### Trivial Changes * Update .github/workflows/stale.yml [skip ci] ([64411ee](64411ee)) ### Dependencies * update @multiformats/multiaddr to 11.0.0 ([#185](#185)) ([539db88](539db88))
|
🎉 This PR is included in version 3.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I simulated that it's not working by attaching a socket to a conn object that I can manually close. Not sure how to trigger the close socket event without hacking (or without calling close on conn)
resolves #179