This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
Remove setTimeout when closing the socket on abort #121
Labels
Comments
Merged
achingbrain
pushed a commit
that referenced
this issue
Sep 21, 2022
Apparently this should be fixed in node@16 which is our min version resolves #121
github-actions bot
pushed a commit
that referenced
this issue
Sep 21, 2022
## [3.0.4](v3.0.3...v3.0.4) (2022-09-21) ### Bug Fixes * remove set timeout ([#182](#182)) ([23518b0](23518b0)), closes [#121](#121) * socket close event not working in browser ([#183](#183)) ([9076b5b](9076b5b)), closes [#179](#179) ### Trivial Changes * Update .github/workflows/stale.yml [skip ci] ([64411ee](64411ee)) ### Dependencies * update @multiformats/multiaddr to 11.0.0 ([#185](#185)) ([539db88](539db88))
|
🎉 This issue has been resolved in version 3.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
We added in #118 a setTimeout to just close the socket in the next event loop, otherwise Node would fail with:
'error'event on aborted requestOnce Node versions fixing this are released and wide spread, we should remove this hack.
Context:
'error'event on aborted request nodejs/node#36931 (comment)The text was updated successfully, but these errors were encountered: