This repository has been archived by the owner on Jun 19, 2023. It is now read-only.
fix: update multiaddr in webrtc connection to include webRTC #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maschad
changed the title
maschad
reviewed
Apr 11, 2023
maschad
reviewed
Apr 11, 2023
maschad
approved these changes
Apr 11, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Apr 11, 2023
## [1.1.2](v1.1.1...v1.1.2) (2023-04-11) ### Bug Fixes * update multiaddr in webrtc connection to include webRTC ([#121](#121)) ([6ea04db](6ea04db))
|
🎉 This PR is included in version 1.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The multiaddr in the webrtc connection would previously not include the webrtc component. This was confusing since if you wanted to see if a connection was over webrtc, checking the multiaddr alone would be wrong.
This sets the multiaddr on a webrtc connection to be
<boostrapMultiaddr>/webrtc/p2p/<peerid>.Closes #120