Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

fix: "invalid ip address" "daemon can be crashed by remote user" #96

Merged
merged 1 commit into from
Jul 31, 2018

Commits on Jul 31, 2018

  1. fix: invalid ip address and daemon can be crashed by remote user

    Per the nodeJS documentation, a Net socket.remoteAddress value may
    be undefined if the socket is destroyed, as by a client disconnect.
    A multiaddr cannot be created for an invalid IP address (such as
    the undefined remote address of a destroyed socket). Currently
    the attempt results in a crash that can be triggered remotely. This
    commit catches the exception in get-multiaddr and returns an
    undefined value to listener rather than throwing an exception when
    trying to process defective or destroyed socket data. Listener then
    terminates processing of the incoming p2p connections that generate
    this error condition.
    
    fixes: libp2p#93
    fixes: ipfs/js-ipfs#1447
    TomCoded committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    4fb70be View commit details
    Browse the repository at this point in the history