Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

Migrate to pull-streams #20

Merged
merged 3 commits into from
Sep 6, 2016
Merged

Migrate to pull-streams #20

merged 3 commits into from
Sep 6, 2016

Conversation

dignifiedquire
Copy link
Member

@dignifiedquire dignifiedquire commented Aug 5, 2016

  • Uses net from node core for now
  • Todo for later, polish pull-net and use that
  • Two failing tests, one is related to unfinished interface-connection, the other needs some investigation.

@dignifiedquire
Copy link
Member Author

Ready for the first round of review, except for two tests all is green

@dignifiedquire dignifiedquire changed the title [WIP] pull-streams Migrate to pull-streams Aug 10, 2016
var listener.listen(function ready () {
console.log('ready')
listener.listen(() => {
console.log('listening')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe as a debug log with more info?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uups looks like I forgot some console.logs

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm this is the readme..

@daviddias
Copy link
Member

@dignifiedquire added documentation on why the pull-streams:

6469760

if 👍, then lets add to all the PRs

const pullToStream = require('pull-stream-to-stream')

const nodeStreamInstance = pullToStream(pullStreamInstance)
// nodeStreamInstance is an istance of a Node.js Stream
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instance not istance

@dignifiedquire
Copy link
Member Author

Thanks @diasdavid. @RichardLitt would appreciate some review on the new documentation.

```

To learn more about his utility, visit https://pull-stream.github.io/#pull-stream-to-stream

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RichardLitt could you review this pull-streams segment. Thank you :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RichardLitt ping :)

@daviddias
Copy link
Member

daviddias commented Sep 1, 2016

Last things to do:

//cc @dignifiedquire

@daviddias
Copy link
Member

Only missing, passing interface-transport tests \o/

@dignifiedquire
Copy link
Member Author

@diasdavid fixed in libp2p/interface-transport#10

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants