-
Notifications
You must be signed in to change notification settings - Fork 40
Migrate to pull-streams #20
Conversation
Ready for the first round of review, except for two tests all is green |
var listener.listen(function ready () { | ||
console.log('ready') | ||
listener.listen(() => { | ||
console.log('listening') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe as a debug log with more info?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uups looks like I forgot some console.log
s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nvm this is the readme..
@dignifiedquire added documentation on why the pull-streams: if 👍, then lets add to all the PRs |
const pullToStream = require('pull-stream-to-stream') | ||
|
||
const nodeStreamInstance = pullToStream(pullStreamInstance) | ||
// nodeStreamInstance is an istance of a Node.js Stream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instance not istance
Thanks @diasdavid. @RichardLitt would appreciate some review on the new documentation. |
``` | ||
|
||
To learn more about his utility, visit https://pull-stream.github.io/#pull-stream-to-stream | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RichardLitt could you review this pull-streams
segment. Thank you :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RichardLitt ping :)
Last things to do:
//cc @dignifiedquire |
f856bf0
to
50abf8a
Compare
Only missing, passing interface-transport tests \o/ |
@diasdavid fixed in libp2p/interface-transport#10 |
net
from node core for nowpull-net
and use thatinterface-connection
, the other needs some investigation.