restructure and add spdy to browser tests #64
Conversation
daviddias
commented
May 22, 2016
daviddias
commented
daviddias
force-pushed
the
add/webrtc-star
branch
from
7a52de6
to
a02c51c
Compare
daviddias
force-pushed
the
add/webrtc-star
branch
from
a02c51c
to
3cd5cbb
Compare
| swarmB.transport.listen('ws', {}, null, cb) | ||
| swarmB.transport.listen('ws', {}, null, () => { | ||
| // swarmB.connection.addStreamMuxer(spdy) | ||
| // swarmB.connection.reuse() |
There was a problem hiding this comment.
@dignifiedquire spdy (or identify) wasn't being used for browser tests and I found that if I run them:
- with spdy - they pass locally, fail on CI
- with identify - they fail
However, this is combination is used in several other places, including orbit. Are these tests missing anything?
There was a problem hiding this comment.
Are you seeing these issues with tcp as well?
There was a problem hiding this comment.
nop. It doesn't even happen with websockets just in Node.js, it only happens in the browser tests
daviddias
force-pushed
the
add/webrtc-star
branch
2 times, most recently
from
eade639
to
a835995
Compare
| swarm1.connection.addStreamMuxer(spdy) | ||
| // swarm1.connection.reuse() | ||
| swarm2.connection.addStreamMuxer(spdy) | ||
| // swarm2.connection.reuse() |
There was a problem hiding this comment.
Also not being successful with Identify on top of webrtc-star (in the browser)
I'm really intrigued, since identify has been a key enabler for Orbit and there are so many successful tests.
daviddias
force-pushed
the
add/webrtc-star
branch
2 times, most recently
from
25e2119
to
b5865fe
Compare
daviddias
force-pushed
the
add/webrtc-star
branch
from
b5865fe
to
d771a12
Compare
|
Going to merge this and update libp2p-ipfs-browser, so that then we can test js-ipfs with bitswap on top of it :) |
