This repository has been archived by the owner on Aug 23, 2019. It is now read-only.
[WIP] Feat/circuit #240
Merged
[WIP] Feat/circuit #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
@victorbjelkholm circle is failing with |
daviddias
suggested changes
Dec 12, 2017
package.json
Outdated
| @@ -51,22 +51,23 @@ | |||
| "peer-book": "~0.5.1", | |||
| "pre-commit": "^1.2.2", | |||
| "pull-goodbye": "0.0.2", | |||
| "pump": "^2.0.0", | |||
There was a problem hiding this comment.
Hmm, it was failing to run on ci because apparently https://github.com/libp2p/js-libp2p-multiplex/blob/fa78df420ca5762b2a003e658fd74bdf1dd3e6b3/src/index.js#L9 is failing to include it as a dep - https://github.com/libp2p/js-libp2p-multiplex/blob/master/package.json#L31..L48. I'll patch js-libp2p-multiplex.
There was a problem hiding this comment.
this should fix the pump issues, as well as port multiplex to use the new aegir libp2p/js-libp2p-mplex#70
|
tests are on the way. |
daviddias
approved these changes
Dec 14, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing circuit dialing