This repository has been archived by the owner on Aug 24, 2023. It is now read-only.
fix: move prom-client to deps #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npm installs peer dependencies by default so there's not much point having `prom-client` in peerDependencies. yarn does not install peer dependencies so then people need to install it separately but there's not much chance of them wanting to collect prometheus metrics without having `prom-client` installed so let's just have it as a regular dep. Fixes ipfs/js-ipfs#4323
maschad
approved these changes
May 23, 2023
github-actions bot
pushed a commit
that referenced
this pull request
May 23, 2023
## [1.1.5](v1.1.4...v1.1.5) (2023-05-23) ### Bug Fixes * move prom-client to deps ([#32](#32)) ([73acad0](73acad0))
|
🎉 This PR is included in version 1.1.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm installs peer dependencies by default so there's not much point having
prom-clientin peerDependencies.yarn does not install peer dependencies so then people need to install it separately but there's not much chance of them wanting to collect prometheus metrics without having
prom-clientinstalled so let's just have it as a regular dep.Fixes ipfs/js-ipfs#4323