This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
Reconsider use of pipe #44
Labels
Comments
Keeping this as low priority for now |
achingbrain
added a commit
that referenced
this issue
Mar 2, 2023
Every iteration of every pipeline function in `it-pipe` crosses an async boundary so it can harm performance if your pipleline would otherwise be synchronous. Fixes #44
Merged
achingbrain
added a commit
that referenced
this issue
Mar 2, 2023
Every iteration of every pipeline function in `it-pipe` crosses an async boundary so it can harm performance if your pipleline would otherwise be synchronous. Fixes #44
🎉 This issue has been resolved in version 6.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
pipe is shown to be an expensive abstraction. In this specific use case it looks like a regular for loop would be enough.
js-libp2p-peer-store/src/address-book.ts
Lines 348 to 366 in 6d7b32c
The text was updated successfully, but these errors were encountered: