refactor: async iterators #94
Conversation
License: MIT Signed-off-by: Alan Shaw <[email protected]>
Thanks @vasco-santos! License: MIT Signed-off-by: Alan Shaw <[email protected]>
License: MIT Signed-off-by: Alan Shaw <[email protected]>
There was a problem hiding this comment.
Just some small comments. I am running the adapter through the benchmarks at https://github.com/libp2p/pull-mplex/tree/master/benchmarks to see what the difference is. I'm hitting some issues with the adapter benchmarks, I'm looking into it. Right now the bench test is really slow and the large file test hangs.
Co-Authored-By: Jacob Heun <[email protected]>
License: MIT Signed-off-by: Alan Shaw <[email protected]>
License: MIT Signed-off-by: Alan Shaw <[email protected]>
License: MIT Signed-off-by: Alan Shaw <[email protected]>
License: MIT Signed-off-by: Alan Shaw <[email protected]>
|
@alanshaw the restrictSize fix took care of the issue with benchmarks. When I was running that the restrict size error ends up getting swallowed and never logged, only abort errors show in the logs. Can we have the source errors propagate up to the logs, they seem to be getting swallowed? |
|
I'll look into it - this still needs work clearly. The slow pingpong benchmark is also worrying. |
License: MIT Signed-off-by: Alan Shaw <[email protected]>
License: MIT Signed-off-by: Alan Shaw <[email protected]>
|
I used npm alias support to install the [email protected] code along side the async test suite to test the adapter, as I was curious about the close tests. It's failing the close tests there as well (both close tests fail for the adapter), so I think there is something wrong with error/close propagation. |
|
@jacobheun I'm working on a fork of the |
License: MIT Signed-off-by: Alan Shaw <[email protected]>
src/coder/decode.js
Outdated
| try { | ||
| this._headerInfo = this._decodeHeader(this._bufferProxy) | ||
| } catch (_) { | ||
| break // not enough data yet...probably |
There was a problem hiding this comment.
Can you elaborate a bit more? The "probably" is not really comforting :)
There was a problem hiding this comment.
Updated the comment for this. We should only hit the break in 2 instances.
- We haven't gotten enough data to parse a header (most common).
- The data we have can't be parsed, likely due to an invalid varint from bad data.
|
Fixed, the BufferList chunks need to be converted before going to node streams .write |
@jacobheun this is https://github.com/alanshaw/it-mplex + the example from this repo updated to use the new API.
Note this includes an adapter class so it can be used immediately in JS IPFS when merged and released. I've run the JS IPFS tests and interop tests against it and they pass!
TODO:
Depends on:
BREAKING CHANGE: This module now has a completely new API based on async iterators. See the README for documentation.