Skip to content
This repository has been archived by the owner on Jun 15, 2023. It is now read-only.

feat: adds support for ed25199 and secp256k1 #31

Merged
merged 3 commits into from
Feb 25, 2019

Conversation

AlbertoElias
Copy link
Contributor

Fixes #30

This is blocked by: libp2p/js-libp2p-crypto-secp256k1#13

@vasco-santos Could you review?

Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @AlbertoElias

Can you rebase this PR with master? We are not using Jenkins CI anymore (travis now), and we need to have it here.

@AlbertoElias
Copy link
Contributor Author

@vasco-santos done!

Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for rebasing the PR @AlbertoElias

LGTM so far.

I would recommend installing the libp2p-crypto-secp256k1: AlbertoElias/js-libp2p-crypto-secp256k1#patch-1, so that you have the id, as well and you are able to add the remaining tests: exportKey and importKey.

@AlbertoElias
Copy link
Contributor Author

@vasco-santos That should be done now. I also updated exporting and importing to fix marshaling.

Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @AlbertoElias ! Thanks

Except for a minor request that I added now, this is good to go, once libp2p-crypto-secp256k1 is released.

src/keychain.js Show resolved Hide resolved
@AlbertoElias
Copy link
Contributor Author

@vasco-santos Everything is fixed, but it seems that what needs updating is libp2p/js-libp2p-crypto#137 I've tampered my package-lock.json to get everything running, but if js-libp2p-crypto decides to do a minor release instead of patch, js-libp2p-keychain's package.json would need to be updated as well

@vasco-santos vasco-santos merged commit 9eb11f4 into libp2p:master Feb 25, 2019
vasco-santos added a commit that referenced this pull request Mar 14, 2019
@raullaprida
Copy link

I'm creating a project using js libp2p and I created a Keystore where I store secp25k1 keys using PEM encrypted PKCS #8. (so now password wouldn't be just for RSA keys). Tests include being able to use OpenSSL to verify the encrypted keys.
Would that be a desired feature for the keychain? (I don't want to make a PR and be automatically rejected)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ed25519 and secp256k1
3 participants