This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
chore: peer-discovery not using peer-info #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
force-pushed
the
chore/peer-discovery-not-using-peer-info
branch
from
f5e99e6
to
d7351fa
Compare
4 tasks
BREAKING CHANGE: peer event emitted with id and multiaddrs properties instead of peer-info
vasco-santos
force-pushed
the
chore/peer-discovery-not-using-peer-info
branch
from
d7351fa
to
48e2f6f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the context of deprecating
peer-infoas described on libp2p/js-libp2p#589, this PR changes thepeer-discoveryinterface to emit an object containing anidproperty and amultiaddrsproperty.We still do not run the interface tests per #44 .
BREAKING CHANGE: peer event emits an object with id and multiaddr instead of a peer-info
Needs: