Skip to content
This repository has been archived by the owner on Jun 26, 2023. It is now read-only.

fix: remove node event emitters #161

Merged
merged 4 commits into from
Feb 10, 2022
Merged

fix: remove node event emitters #161

merged 4 commits into from
Feb 10, 2022

Conversation

achingbrain
Copy link
Member

@achingbrain achingbrain commented Feb 9, 2022 •
edited
Loading

Replaces the node EventEmitter with the pure-js EventTarget class.

All events are now instances of Event.

For typing CustomEvent can be used which gives us a typed .detail field.

Tediously EventTarget itself doesn't support typed events (yet?) and node.js doesn't support CustomEvent globally so bit of trickery was required but hopefully this can be removed in future:

import { EventEmitter, CustomEvent } from '@libp2p/interfaces'

interface EventMap {
  'foo': CustomEvent<number>
}

class MyEmitter extends EventEmitter<EventMap> {
  // ... other code here
} 

const emitter = new MyEmitter()

emitter.addEventListener('foo', (evt) => {
  const n = evt.detail // n is a 'number'
})

@achingbrain achingbrain merged commit 221fb6a into master Feb 10, 2022
@achingbrain achingbrain deleted the fix/remove-node-event-emitters branch February 10, 2022 05:43
github-actions bot pushed a commit that referenced this pull request Feb 10, 2022
@semantic-release-bot
chore(release): 1.3.1 [skip ci]
ed3e0ae 
## [@libp2p/interfaces-v1.3.1](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/interfaces-v1.3.0...@libp2p/interfaces-v1.3.1) (2022-02-10)

### Bug Fixes

* remove node event emitters ([#161](#161)) ([221fb6a](221fb6a))
@github-actions
Copy link

🎉 This PR is included in version @libp2p/interfaces-v1.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Feb 10, 2022
@semantic-release-bot
chore(release): 1.0.2 [skip ci]
d15bff4 
## [@libp2p/logger-v1.0.2](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/logger-v1.0.1...@libp2p/logger-v1.0.2) (2022-02-10)

### Bug Fixes

* remove node event emitters ([#161](#161)) ([221fb6a](221fb6a))
@github-actions
Copy link

🎉 This PR is included in version @libp2p/logger-v1.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Feb 10, 2022
@semantic-release-bot
chore(release): 1.1.1 [skip ci]
df78034 
## [@libp2p/peer-id-v1.1.1](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/peer-id-v1.1.0...@libp2p/peer-id-v1.1.1) (2022-02-10)

### Bug Fixes

* remove node event emitters ([#161](#161)) ([221fb6a](221fb6a))
@github-actions
Copy link

🎉 This PR is included in version @libp2p/peer-id-v1.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Feb 10, 2022
@semantic-release-bot
chore(release): 1.0.1 [skip ci]
43cf66e 
## [@libp2p/tracked-map-v1.0.1](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/tracked-map-v1.0.0...@libp2p/tracked-map-v1.0.1) (2022-02-10)

### Bug Fixes

* remove node event emitters ([#161](#161)) ([221fb6a](221fb6a))
@github-actions
Copy link

🎉 This PR is included in version @libp2p/tracked-map-v1.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Feb 10, 2022
@semantic-release-bot
chore(release): 1.1.1 [skip ci]
a71e08c 
## [@libp2p/topology-v1.1.1](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/topology-v1.1.0...@libp2p/topology-v1.1.1) (2022-02-10)

### Bug Fixes

* remove node event emitters ([#161](#161)) ([221fb6a](221fb6a))
@github-actions
Copy link

🎉 This PR is included in version @libp2p/topology-v1.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Feb 10, 2022
@semantic-release-bot
chore(release): 1.0.4 [skip ci]
f996d49 
## [@libp2p/peer-id-factory-v1.0.4](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/peer-id-factory-v1.0.3...@libp2p/peer-id-factory-v1.0.4) (2022-02-10)

### Bug Fixes

* remove node event emitters ([#161](#161)) ([221fb6a](221fb6a))
@github-actions
Copy link

🎉 This PR is included in version @libp2p/peer-id-factory-v1.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Feb 10, 2022
@semantic-release-bot
chore(release): 1.2.1 [skip ci]
877865e 
## [@libp2p/pubsub-v1.2.1](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/pubsub-v1.2.0...@libp2p/pubsub-v1.2.1) (2022-02-10)

### Bug Fixes

* remove node event emitters ([#161](#161)) ([221fb6a](221fb6a))
@github-actions
Copy link

🎉 This PR is included in version @libp2p/pubsub-v1.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Feb 10, 2022
@semantic-release-bot
chore(release): 1.1.1 [skip ci]
abc653e 
## [@libp2p/interface-compliance-tests-v1.1.1](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/interface-compliance-tests-v1.1.0...@libp2p/interface-compliance-tests-v1.1.1) (2022-02-10)

### Bug Fixes

* remove node event emitters ([#161](#161)) ([221fb6a](221fb6a))
@github-actions
Copy link

🎉 This PR is included in version @libp2p/interface-compliance-tests-v1.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Feb 10, 2022
@semantic-release-bot
chore(release): 1.1.1 [skip ci]
0a1e569 
## [@libp2p/connection-v1.1.1](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/connection-v1.1.0...@libp2p/connection-v1.1.1) (2022-02-10)

### Bug Fixes

* remove node event emitters ([#161](#161)) ([221fb6a](221fb6a))
@github-actions
Copy link

🎉 This PR is included in version @libp2p/connection-v1.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Feb 10, 2022
@semantic-release-bot
chore(release): 1.0.1 [skip ci]
6b9c9c0 
## [@libp2p/peer-record-v1.0.1](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/peer-record-v1.0.0...@libp2p/peer-record-v1.0.1) (2022-02-10)

### Bug Fixes

* remove node event emitters ([#161](#161)) ([221fb6a](221fb6a))
@github-actions
Copy link

🎉 This PR is included in version @libp2p/peer-record-v1.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Feb 10, 2022
@semantic-release-bot
chore(release): 1.0.1 [skip ci]
cf00605 
## [@libp2p/peer-store-v1.0.1](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/peer-store-v1.0.0...@libp2p/peer-store-v1.0.1) (2022-02-10)

### Bug Fixes

* remove node event emitters ([#161](#161)) ([221fb6a](221fb6a))
@github-actions
Copy link

🎉 This PR is included in version @libp2p/peer-store-v1.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@daeyeon daeyeon mentioned this pull request Jun 21, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@achingbrain