Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add connect tests using secio and noise #40

Merged
merged 2 commits into from
May 14, 2020
Merged

Conversation

vasco-santos
Copy link
Member

This PR replaces #32 for adding interop tests for secio and noise, since after #37 being merged using a folder structure with each key, the #32 PR got a complex task to rebase.

This PR adds exactly the same as #32

  • The connect tests can now be run with different configurations to make it easier to run those suites for both secio and noise.
  • Enabled the ability to specify local daemons when running the tests to make verifying go daemon changes easier. Doing this is noted in the readme.

Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one minor thing from the last PR I hadn't updated.

src/daemon.js Outdated Show resolved Hide resolved
@vasco-santos vasco-santos merged commit 66e1f62 into master May 14, 2020
@vasco-santos vasco-santos deleted the feat/crypto-test branch May 14, 2020 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants