Remeasure round trip time #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
previously requested changes
Jan 6, 2022
periodically re-measure round trip time
hannahhoward
force-pushed
the
feat/update-rtt
branch
from
9ca702b
to
4cc3cce
Compare
|
2022-08-26 conversation: we're wondering if this is the right fix or whether transports expose a RTT. Next step is for @marten-seemann to review again and figure out next steps. We will do this for this 0.23 go-libp2p release. |
21 tasks
marten-seemann
requested review from
Stebalien and
MarcoPolo
and removed request for
marten-seemann
|
I made a few changes to this PR:
|
Merged
MarcoPolo
reviewed
Sep 7, 2022
| @@ -335,7 +335,25 @@ func (s *Session) measureRTT() { | |||
| if err != nil { | |||
| return | |||
| } | |||
| atomic.StoreInt64(&s.rtt, rtt.Nanoseconds()) | |||
| if !atomic.CompareAndSwapInt64(&s.rtt, 0, rtt.Nanoseconds()) { | |||
| prev := atomic.LoadInt64(&s.rtt) | |||
There was a problem hiding this comment.
Doing this is no longer atomic, is that okay?
There was a problem hiding this comment.
I think it is. Worst thing that can happen is that we read the RTT again in getRTT. I agree that it's ugly.
MarcoPolo
approved these changes
Sep 7, 2022
zllovesuki
pushed a commit
to zllovesuki/go-yamux
that referenced
this pull request
Jan 23, 2023
* feat(session): remeasure round trip time periodically re-measure round trip time * feat(session): measure rtt during keep-alive * refactor(session): repeat measure rtt via timer * fix(session): fix flaky test * simplify RTT timer by using a time.Ticker * calculate a smoothed RTT Co-authored-by: Marten Seemann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Keep round trip time up to date. This just updates the measured round trip time any time the keep alive timeout is called.