fix: unlock recvLock in all cases. #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, we could block on a call to stream.Read forever.
Stebalien
force-pushed
the
fix/recv-deadlock
branch
from
15bff30
to
dae8a2b
Compare
willscott
approved these changes
Apr 18, 2020
| // 1. We don't accept a message that's too big. | ||
| // 2. We unlock after resetting the stream. | ||
| for i := uint32(1); i < 100; i += 2 { | ||
| func() { |
There was a problem hiding this comment.
the anonymous function is just to set the scope for the defers? can probably be removed and the closes put at bottom of the loop
There was a problem hiding this comment.
I'm trying to avoid leaking anything, even on fatal errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, we could block on a call to stream.Read forever.