This repository has been archived by the owner on May 14, 2020. It is now read-only.
Shim for Connection Gater #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 9, 2020
raulk
suggested changes
May 13, 2020
There was a problem hiding this comment.
I think we're better off putting this in go-libp2p as a utility method, and pointing to it from the // Deprecated comment on the Filters option, than putting this here and introducing a dependency on go-libp2p-core. WDYT, @aarshkshah1992?
|
This shim will live in go-libp2p. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For libp2p/go-libp2p#872.
This PR implements an adaptor/shim for
Filtersthat transforms it to a ConnectionGater.This is required because Swarm etc no longer use a
Filterand sogo-libp2ptransforms aFilterto aConnectionGaterif noConnectionGaterhas been explicitly configured by the user.