fix: don't try to marshal a nil record #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
force-pushed
the
fix/record-panic
branch
from
60fcc56
to
01da330
Compare
willscott
reviewed
May 20, 2020
| @@ -428,9 +428,6 @@ func (ids *IDService) getSnapshot() *identifySnapshot { | |||
| if !ids.disableSignedPeerRecord { | |||
| if cab, ok := peerstore.GetCertifiedAddrBook(ids.Host.Peerstore()); ok { | |||
| snapshot.record = cab.GetPeerRecord(ids.Host.ID()) | |||
| if snapshot.record == nil { | |||
| log.Errorf("latest peer record does not exist. identify message incomplete!") | |||
There was a problem hiding this comment.
not worth a log when this occurs? seems at least debug worthy
There was a problem hiding this comment.
Yeah, maybe as a debug entry. However, it'll happen whenever we don't have addresses.
There was a problem hiding this comment.
You know, I'm going to be petty. It's not worth the extra indent I'd need to handle that case.
There was a problem hiding this comment.
Our debug logging is to verbose to be useful anyways.
willscott
approved these changes
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #939