Consolidate abstractions and core types into go-libp2p-core #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
7 tasks
This was referenced May 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of a batch across go-libp2p repos to consolidate abstractions, interfaces and core types into libp2p/go-libp2p-core. See branch
consolidate-skeletonthere.Work is being performed in the
consolidate-skeletonbranch across repos.This repo contains no abstractions, but minor backwards-compatible changes are required.
Hostinterface was referencing thego-multistream.MultistreamMuxerstruct type. It now references theprotocol.Switchinterface that in turn embeds aprotocol.Routerand aprotocol.Negotiator. These interfaces were extracted out of the concrete typeMultistreamMuxer.Merge strategy: squash and rebase.