Improve observed address handling #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allocates and eats a lot of cpu time under the lock; let a background worker gc periodically.
ghost
assigned 
|
I think we can improve further by using a read/write lock, as there is now a single writer and many readers. |
Stebalien
approved these changes
Apr 9, 2019
p2p/protocol/identify/obsaddr.go
Outdated
| oas := &ObservedAddrSet{ | ||
| addrs: make(map[string][]*ObservedAddr), | ||
| ttl: pstore.OwnObservedAddrTTL, | ||
| wch: make(chan newObservation, 1), |
There was a problem hiding this comment.
Let's make this longer, like 64 or something (or at least 16). We want as many observed addrs as we can on initial start.
There was a problem hiding this comment.
Ok, will set to 16 (= 4 * activation-threshold)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overhauls the observed address set to be more friendly to relays:
Closes #584