Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

identify: avoid parsing/printing multiaddrs #583

Merged
merged 1 commit into from
Apr 9, 2019
Merged

identify: avoid parsing/printing multiaddrs #583

merged 1 commit into from
Apr 9, 2019

Conversation

Stebalien
Copy link
Member

  1. Don't bother formatting the address as a string.
  2. Use SplitFirst to avoid parsing the entire address.

@ghost ghost assigned Stebalien Apr 9, 2019
@ghost ghost added the status/in-progress In progress label Apr 9, 2019
@Stebalien
Copy link
Member Author

slight perf improvement (1.4x speedup).

@vyzo vyzo merged commit 9051b3c into master Apr 9, 2019
@ghost ghost removed the status/in-progress In progress label Apr 9, 2019
@vyzo vyzo deleted the fix/faster-observer branch April 9, 2019 08:12
@vyzo vyzo mentioned this pull request Apr 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyzo vyzo vyzo approved these changes

Assignees

@Stebalien Stebalien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stebalien @vyzo