move things outside of the lock in obsaddr #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
whyrusleeping
force-pushed
the
feat/reduce-lock-contention
branch
from
f472c2f
to
a7eb2ef
Compare
|
okay, after rebasing the perf gains arent quite as nice, but still 25 seconds to 11 seconds. |
Stebalien
approved these changes
Apr 9, 2019
Stebalien
force-pushed
the
feat/reduce-lock-contention
branch
from
4e48292
to
aebe405
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test added here is just to benchmark the effect of lock contention. In my tests, this patch makes things ~4x faster (54 seconds to 14.5 seconds)