Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

circuitv2: Update proto files to proto3 #2121

Merged
merged 2 commits into from
Feb 22, 2023
Merged

circuitv2: Update proto files to proto3 #2121

merged 2 commits into from
Feb 22, 2023

Conversation

MarcoPolo
Copy link
Collaborator

@MarcoPolo MarcoPolo commented Feb 22, 2023 •
edited
Loading

closes #2029

I just copied the pb definition from specs directly and ran go generate.

The gist is that this goes from required to optional.

@marten-seemann
Copy link
Contributor

How is this different from #2029?

@MarcoPolo
Copy link
Collaborator Author

Same idea, but:

  1. I copied the comments from the specs so they show up in the field comments.
  2. I created this before @ckousik updated the voucher proto.
  3. I kept the name ReservationVoucher to not change any existing code.

Full diff here: https://gist.github.com/MarcoPolo/9fafd391036f7805e5815b62cbe5d407

@marten-seemann marten-seemann mentioned this pull request Feb 22, 2023
Closed
25 tasks
@MarcoPolo MarcoPolo merged commit cb45229 into master Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marten-seemann marten-seemann marten-seemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcoPolo @marten-seemann