Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

respect the user's security protocol preference order #1908

Closed
wants to merge 3 commits into from
Closed

respect the user's security protocol preference order #1908

wants to merge 3 commits into from

Conversation

marten-seemann
Copy link
Contributor

Fixes #1906. Depends on #1907.

@marten-seemann marten-seemann force-pushed the security-protocol-order branch 2 times, most recently from 4e1aeba to 5083960 Compare November 20, 2022 10:02
@marten-seemann marten-seemann deleted the branch expose-security November 21, 2022 21:47
@marten-seemann
Copy link
Contributor Author

GitHub wtf: I deleted the expose-security branch, because #1907 was merged. Then GitHub automatically closed this PR, which was still targeting expose-security. Now I can't retarget it to master, because for some reason you can't retarget closed PRs. I also can't reopen it because expose-security is gone. Well thanks for that.

@marten-seemann marten-seemann mentioned this pull request Nov 21, 2022
Merged
MarcoPolo
MarcoPolo reviewed Nov 21, 2022
View reviewed changes
Copy link
Collaborator

@MarcoPolo MarcoPolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit gross, but I don't really have a better idea.

@marten-seemann
Copy link
Contributor Author

Recreated as #1912.

@marten-seemann marten-seemann deleted the security-protocol-order branch November 21, 2022 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoPolo MarcoPolo MarcoPolo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marten-seemann @MarcoPolo