fix: autorelay: add some guard rails and docs #1863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoPolo
changed the title
marten-seemann
approved these changes
Nov 8, 2022
There was a problem hiding this comment.
LGTM.
In the long term, we can think about a nicer API, as I suggested in #1852 (comment). That won't make it into a patch release though.
|
Agreed. Opened an issue here: #1866 Let's merge this for the patch release. |
MarcoPolo
added a commit
that referenced
this pull request
Nov 9, 2022
MarcoPolo
added a commit
that referenced
this pull request
Nov 9, 2022
* fix: return filtered addrs (#1855) * Bump version * Fix concurrent map access in connmgr (#1860) * Add some guard rails and docs (#1863) Co-authored-by: Dennis Trautwein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1852 by adding guard rails and some more documentation.