feat: switch noise to use minio's SHA256 implementation #1657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On my 11th gen Intel laptop, this library is 3x faster than the default
one (and is the one we use in go-multihash).
See below (GEN_ is the builtin version, SHA_ is this library).
BenchmarkHash/SHA_/8Bytes-8 94.31 ns/op 84.82 MB/s
BenchmarkHash/SHA_/1K-8 926.9 ns/op 1104.74 MB/s
BenchmarkHash/SHA_/8K-8 6793 ns/op 1205.98 MB/s
BenchmarkHash/SHA_/1M-8 883694 ns/op 1186.58 MB/s
BenchmarkHash/SHA_/5M-8 4347298 ns/op 1206.01 MB/s
BenchmarkHash/SHA_/10M-8 8810864 ns/op 1190.09 MB/s
BenchmarkHash/GEN_/8Bytes-8 283.2 ns/op 28.25 MB/s
BenchmarkHash/GEN_/1K-8 3587 ns/op 285.48 MB/s
BenchmarkHash/GEN_/8K-8 27706 ns/op 295.68 MB/s
BenchmarkHash/GEN_/1M-8 3414827 ns/op 307.07 MB/s
BenchmarkHash/GEN_/5M-8 16789216 ns/op 312.28 MB/s
BenchmarkHash/GEN_/10M-8 34073478 ns/op 307.74 MB/s
marten-seemann
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my 11th gen Intel laptop, this library is 3x faster than the default
one (and is the one we use in go-multihash).
See below (GEN_ is the builtin version, SHA_ is this library).