Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: getting interop between js and go swarm #12

Closed
wants to merge 2 commits into from

Conversation

daviddias
Copy link
Member

No description provided.

metrics "github.com/ipfs/go-libp2p/p2p/metrics"
tu "github.com/ipfs/go-libp2p/testutil"
ma "github.com/jbenet/go-multiaddr"
swarm "go-libp2p/p2p/net/swarm"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to understand why for swarm and peer it didn't complain that I didn't add github.com/ipfs to the path

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this build? That seems wrong to me...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, this doesnt build for me

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shed some light :) I'm trying to get it to work too. I was hoping that I could use gx, but installing globally is hanging whyrusleeping/gx#23

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just add github.com/ipfs/ to the imports, and make sure that GO15VENDOREXPERIMENT is set to 1. it should work. (i'll try it too)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you'll also need to change the multiaddr import to use the vendored one:

    ma "gx/QmVUi2ncqnU48zsPgR1rQosDGwY3SSZ1Ndp33j33YjXdsj/go-multiaddr"

This is because of go's stupid insistence that the import path of a type is part of the type.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you dont want to type this manually, just run gx-go rewrite from the go-libp2p directory (the one with the package.json in it)

@daviddias daviddias closed this Mar 3, 2016
@daviddias daviddias deleted the interop/swarm branch March 3, 2016 08:19
marten-seemann pushed a commit that referenced this pull request Jan 3, 2022
add a timeout to Provide in routing.Advertise
marten-seemann pushed a commit that referenced this pull request Jan 9, 2022
add a timeout to Provide in routing.Advertise
marten-seemann pushed a commit that referenced this pull request Apr 22, 2022
marten-seemann pushed a commit that referenced this pull request Apr 22, 2022
copy default config to account for new struct members
marten-seemann pushed a commit that referenced this pull request Apr 26, 2022
marten-seemann pushed a commit that referenced this pull request Apr 27, 2022
It's unmaintained and pulls in github.com/whyrusleeping/cbor. This patch
explicitly re-implements the minimally needed features.

Also fixes #12.
marten-seemann added a commit that referenced this pull request Apr 27, 2022
remove unneeded marshaling / unmarshaling when generating cert chain
marten-seemann pushed a commit that referenced this pull request May 26, 2022
marten-seemann pushed a commit that referenced this pull request Aug 9, 2022
Add SetProtocols method to peerstore
marten-seemann pushed a commit that referenced this pull request Aug 15, 2022
marten-seemann pushed a commit that referenced this pull request Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants