don't use a context for closing the ObservedAddrManager #1175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
id-service-shutdown
branch
from
60b5098
to
5098b94
Compare
marten-seemann
changed the title
marten-seemann
force-pushed
the
id-service-shutdown
branch
from
5098b94
to
2cf1c45
Compare
Stebalien
requested changes
Sep 7, 2021
marten-seemann
force-pushed
the
id-service-shutdown
branch
from
515d043
to
db0bc33
Compare
Stebalien
approved these changes
Sep 7, 2021
marten-seemann
commented
Sep 7, 2021
p2p/protocol/identify/obsaddr.go
Outdated
|
|
||
| oas.mu.Lock() | ||
| oas.refreshTimer.Stop() | ||
| oas.refreshTimer = nil |
There was a problem hiding this comment.
This doesn't work as the worker might be blocked on the timer channel, creating a race condition.
There was a problem hiding this comment.
Eh, we could have a "shutdown" boolean. That or have the worker keep a copy of the timer and/or channel locally instead of reading oas.refreshTimer.
marten-seemann
force-pushed
the
id-service-shutdown
branch
from
db0bc33
to
9342776
Compare
Stebalien
approved these changes
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the ongoing effort to stop using contexts to control shutdowns.
Most importantly, this PR removes a dependency on the swarm's
Processingo-libp2p/p2p/protocol/identify/obsaddr.go
Line 257 in fd4d2a4